Add intersection/union types to `_primary_type`

tree-sitter / tree-sitter-typescript

TypeScript grammar for tree-sitter

MIT License

361 stars 108 forks source link

Add intersection/union types to `_primary_type` #201

Closed kraftwerk28 closed 2 years ago

kraftwerk28 commented 2 years ago

Checklist:

[x] All tests pass in CI.
[x] There are sufficient tests for the new fix/feature.
[x] Grammar rules have not been renamed unless absolutely necessary.
[x] The conflicts section hasn't grown too much.
[x] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

mjambon commented 2 years ago

Should union_type and intersection_type be removed from _type since they're now included with _primary_type? If not, maybe leave a comment explaining why.

kraftwerk28 commented 2 years ago

You're right.

mjambon commented 2 years ago

great, thank you and sorry for the delay.