search

tree-sitter / tree-sitter-typescript

TypeScript grammar for tree-sitter
MIT License
335 stars 104 forks source link

Remove and ignore yarn.lock, since we use npm #216

Closed hendrikvanantwerpen closed 2 years ago

hendrikvanantwerpen commented 2 years ago

The presence of yarn.lock in the repository is confusing and seems unnecessary, since we use NPM exclusively. This PR removes yarn.lock and ignores it in .gitignore, similarly to what we do with other secondary locak files sucha s Cargo.lock.

I could not figure out where Yarn is invoked. Perhaps some of the projects in examples use it and visiting those (e.g., in an IDE) result in the lock file? It does not seem to be used by any of our primary scripts for building and testing, so I see no obvious harm in simply ignoring it.

Fixes #211.

maxbrunsfeld commented 2 years ago

Thanks @hendrikvanantwerpen!

resolritter commented 2 years ago

Now it makes sense to introduce a package-lock.json file for NPM, right? Or is the project not using lockfiles for some reason? The lack of it leads to undeterministic builds: https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json.