search

treebeardtech / nbmake

📝 Pytest plugin for testing notebooks
https://pypi.org/project/nbmake/
Apache License 2.0
189 stars 18 forks source link

Passing `-Werror` to `pytest --nbmake` has no effect #104

Open garrison opened 1 year ago

garrison commented 1 year ago

Describe the bug Passing -Werror to pytest --nbmake has no effect. It should, instead, cause the tests to fail if the code in a notebook causes a warning.

To Reproduce Steps to reproduce the behavior:

  1. Create a notebook which emits a warning.
  2. Run it using pytest --nbmake --Werror **/*ipynb

Expected behavior I expect tests to fail.

alex-treebeard commented 1 year ago

hi @garrison, thanks for this report. We generally intend to follow conventions in pytest so I'll mark this one as a bug.