search

treebeardtech / nbmake

📝 Pytest plugin for testing notebooks
https://pypi.org/project/nbmake/
Apache License 2.0
179 stars 18 forks source link

chore: run bump-pydantic #108

Closed ThibaultFy closed 1 year ago

ThibaultFy commented 1 year ago

Run the pydantic script bump-pydantic to allow the migration to pydantic 2.0.*

ThibaultFy commented 1 year ago

I have some errors when running the tests locally (MacOS). i.e: 

FAILED tests/test_nb_run.py::TestNotebookRun::test_when_mock_then_succeeds - assert NotebookError(summary='\x1b[0;31mAssertionErr...
FAILED tests/test_nb_run.py::TestNotebookRun::test_when_post_cell_execute_then_succeeds - AssertionError: assert NotebookError(su...
FAILED tests/test_nb_run.py::TestNotebookRun::test_when_post_cell_execute_then_command_fails - Failed: DID NOT RAISE <class 'Exce...
FAILED tests/test_nb_run.py::TestNotebookRun::test_when_import_error_then_fails - TypeError: __init__() got an unexpected keyword...
FAILED tests/test_pytest_plugin.py::test_when_parallel_passing_nbs_then_ok - AssertionError: assert <ExitCode.USAGE_ERROR: 4> == ...
FAILED tests/test_pytest_plugin.py::test_when_no_import_errs_then_pass - AssertionError: assert <ExitCode.USAGE_ERROR: 4> == <Exi...
FAILED tests/test_pytest_plugin.py::test_when_not_json_then_correct_err_msg - assert 'NBMAKE INTERNAL ERROR' not in 'NBMAKE INTE....

This seems unrelated to Pydantic. Do I miss some configuration ?

ThibaultFy commented 1 year ago

Linked issue: https://github.com/treebeardtech/nbmake/issues/107

alex-treebeard commented 1 year ago

thanks for this @ThibaultFy! The CI pipeline is a bit rusty but we should definitely get this issue unblocked.

alex-treebeard commented 1 year ago

Hi @ThibaultFy I have just removed our minimal pydantic dependency in v1.4.3 -- thanks for raising this!