search

treebeardtech / nbmake

📝 Pytest plugin for testing notebooks
https://pypi.org/project/nbmake/
Apache License 2.0
179 stars 18 forks source link

Bump python requirement to 3.8 fix dependency problem. #117

Closed tetov closed 7 months ago

tetov commented 7 months ago

Closes #116

As described in #116, this could also be solved by changing the dep on importlib-metadata to <6.8.0.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ed5eb12) 92.14% compared to head (d2f3671) 93.08%.

:exclamation: Current head d2f3671 differs from pull request most recent head f6e0d87. Consider uploading reports for the commit f6e0d87 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   92.14%   93.08%   +0.93%     
==========================================
  Files           4        4              
  Lines         191      188       -3     
==========================================
- Hits          176      175       -1     
+ Misses         15       13       -2
Files Coverage Δ
src/nbmake/pytest_plugin.py 92.59% <100.00%> (+5.92%) :arrow_up:
alex-treebeard commented 7 months ago

Thanks for this @tetov, as discussed in your issue I support your reasoning in dropping 3.7 support for subsequent releases.

The tests for 3.8 are failing and it's possibly a simple fix - specify test dependency to IPython <=8.12

ImportError: IPython 8.13+ supports Python 3.9 and above, following NEP 29. IPython 8.0-8.12 supports Python 3.8 and above, following NEP 29.

I'm conscious that if this is not as simple to fix it may highlight some work needed on the testing solution for this package...please let me know how it goes and I can help get this put into a release.

tetov commented 7 months ago

I should have tested on 3.8 but didn't since I couldn't apt install python3.8.. Might be easiest to use act to do tests on multiple versions.

Can you please hold off on dropping 3.8 from tests (as in #118) until I have done some work here first?

alex-treebeard commented 7 months ago

Thanks @tetov, I'm going to release this now (devcontainer error is not critical)

alex-treebeard commented 7 months ago

Released in 1.5.0, thanks a lot for the contribution!

tetov commented 7 months ago

Happy to help! Want me to upgrade poetry in devcontainers?

alex-treebeard commented 6 months ago

yes please, that would be awesome