search

treebeardtech / nbmake

📝 Pytest plugin for testing notebooks
https://pypi.org/project/nbmake/
Apache License 2.0
184 stars 18 forks source link

add command line option for timeout #50

Closed rabernat closed 2 years ago

rabernat commented 2 years ago

Thanks for making this very useful plugin! 🙏

Is your feature request related to a problem? Please describe.

I have some very slow notebooks that need a long timeout (longer than the default of 300s). I'm finding it inconvenient to edit the notebook json metadata manually, i.e. adding

  "execution": {
    "timeout": 3000
  },

Describe the solution you'd like

It would be great to be able to instead specify this option on the command line from pytest, e.g. 

pytest --nbmake-timeout=3000 --nbmake notebook.ipynb
alex-treebeard commented 2 years ago

Great idea @rabernat , thanks for the write up.

I reckon I'll add this arg in the next week.

alex-treebeard commented 2 years ago

@rabernat I've released 1.0 with this feature

rabernat commented 2 years ago

Amazing! Thank you so much!