search

treebeardtech / nbmake

📝 Pytest plugin for testing notebooks
https://pypi.org/project/nbmake/
Apache License 2.0
182 stars 18 forks source link

Bump nbclient to >= 0.5.13 in deps #65

Closed cisaacstern closed 2 years ago

cisaacstern commented 2 years ago

Closes #63 per suggestion by @alex-treebeard in https://github.com/treebeardtech/nbmake/issues/63#issuecomment-1064991987

cisaacstern commented 2 years ago

Tests are apparently failing because poetry can't find nbclient ^0.5.13. I'm not sure what the fix is for that.

alex-treebeard commented 2 years ago

Thanks for this PR! Try deleting the poetry.lock as it may be confused about this reqs change.

cisaacstern commented 2 years ago

I removed poetry.lock as suggested. When I tried to rebuild locally, poetry told me that nbclient 0.5.13 requires python ^3.7.0 (which does appear to be true) so I bumped that as well.

alex-treebeard commented 2 years ago

Thanks for the help with this @cisaacstern , I fixed the remaining issue and have released 1.3.0

https://github.com/treebeardtech/nbmake/pull/66

cisaacstern commented 2 years ago

Thanks, @alex-treebeard!