Closed carlodri closed 2 years ago
Thanks for raising this @carlodri, It seems that we can't remove fspath
without breaking pytest 6 users.
I reckon we either leave it as is for the moment or pivot off the version number with pkg_resources.get_distribution("pytest").version
Are you able to silence this warning for now?
you can silence the warning with --disable-warnings but since this is deprecated, it means it will be removed from upcoming releases. you can either introduce a backward compatible solution that works for both versions. Or pytest 6 can continue using this version of nbmake. You need to be able to progress the project.
Hi @ygilany, do you think future releases of nbmake need to support pytest 6?
@alex-treebeard thank you, it's not a big problem for me. Just reporting because at a certain point it will require some changes to adapt to future versions of pytest.
Thank you for the great package by the way!
@alex-treebeard sorry for not seeing this sooner. I do believe the library should be able to keep upgrading to newer packages. Ultimately the decision is yours as the library maintainer. But your alternatives are (stating the obvious but verbalizing it):
Thanks for bumping this @Ygilany, I've gone with option 3, released on 1.3.3
Describe the bug Deprecation warning appears when starting pytest using
platform: darwin, Python 3.10.4, pytest 7.1.2, pytest-sugar 0.9.4
andnbmake-1.3.0
:Desktop (please complete the following information):