treecaptcha / uwu

Uwuify any Spigot/Paper/Purpur server
MIT License
5 stars 1 forks source link

Bump to 1.19.2 and fix config save issue #2

Closed Roosterseatyou closed 2 years ago

Roosterseatyou commented 2 years ago

Bumps to 1.19.2 with chat previewing supported as well as a config option to allow/disallow the chat preview to show. This also fixes #1 :)

treecaptcha commented 2 years ago

Everything here mostly seems good, one thing is that the uwuifier uses a random number generator and it does not guarantee that two runs of the same text will get the same output. One way to mitigate this would be to hash the string into a random seed through some fast hashing algorithm.

Also, we may want to look at the performance impact of getting the config value every time vs getting the value from a static variable as the static variable will probably be faster.

Thx for fixing #1 btw :)

- TreeCaptcha (iCaffeine)

treecaptcha commented 2 years ago

seems good will merge after someone tests it :p I'll make a release on merge too.

Roosterseatyou commented 2 years ago

All is working as intended!

treecaptcha commented 2 years ago

Update to 1.19.2