treee111 / wahooMapsCreator

Create maps for Wahoo device based on latest OSM maps
GNU General Public License v3.0
259 stars 26 forks source link

[DEV] Use geofabrik .json for countries and regions for internal processing (from former `constants.py` and `wahoomc/resources/json`) #182

Closed treee111 closed 1 year ago

treee111 commented 1 year ago

This PR…

Considerations and implementations

This PR takes away local hardcoded values in constants.py and wahoomc/resources/json/ by using fresh downloaded geofabrik .json therefore. This ensures

and most important:

The local wahoomc/resources/json/ files are still there and the -co as well as -xy coding uses it. The reason is that X/Y processing at the time of writing is not integrated using geofabrik .json. For comparison of local json/ and geofabrik .json output, the files are still there for now. In the next PR, all that will be done.

How to test

  1. do usual tests
  2. run unittests

Pull Request Checklist