search

treee111 / wahooMapsCreator

Create maps for Wahoo device based on latest OSM maps
247 stars 25 forks source link

Consider switching to pyhgtmap (fork) for contour lines #217

Open quietvoid opened 1 year ago

quietvoid commented 1 year ago

Is your feature request related to a problem? Please describe.

The latest phyghtmap release does not work very well with latest Python and matplotlib versions. Someone forked it into pyhgtmap however wahoomc has a hardcoded binary to phyghtmap.

Describe the solution you'd like

A way to specify the binary, or maybe setting the default used binary to the new fork while having a fallback to the old version.

Describe alternatives you've considered

Currently I just made a symbolic link, pyhgtmap seems to have backwards compatibility and I was able to create a map.

Unfortunately I think it's not Windows compatible yet: https://github.com/agrenott/pyhgtmap/issues/7

treee111 commented 9 months ago

Hi @quietvoid, thanks for pointing to the fork pyhgtmap! It's a good idea since phyghtmap is difficult to install.

Windows support seams like a blocker for me, so we would have a different tool per OS. With the downsides of enhancing and making documentation more difficult, maybe equalness of results, ... Supporting both tools for macOS with a switch or "if pyhgtmap is there use it, fallback on phyghtmap" would also have identical downsindes in my opinion.

However I tried it and it works for me on macOS. Feel free to try out the changes in #234 and if it works on your device.

quietvoid commented 9 months ago

Thanks. I haven't tested but the code looks like it would work. I don't mind sticking to symbolic links, it works with the current wahoomc code.