treee111 / wahooMapsCreator

Create maps for Wahoo device based on latest OSM maps
247 stars 25 forks source link

[FEAT] Use proper tool name in error message, reference Osmium or osmconvert #232

Closed alfh closed 9 months ago

alfh commented 9 months ago

This PR…

Considerations and implementations

I assume this is a left over, copy/paste error, or that the osmosis was used for this phase earlier. Tidy up the message, so it is clear where osmium is used and where osmosis is used.

Also wonder a bit why osmconvert is used on Windows, and not Osmium, I would assume we prefer to use the same tools on Windows and Linux, to keep things simple and similar. But that is not relevant for this PR.

How to test

  1. ...
  2. ...

Pull Request Checklist

treee111 commented 9 months ago

thanks for the unification PR! Also noticed that while researching for your question https://github.com/treee111/wahooMapsCreator/issues/229#issuecomment-1817770427. cleaned up the PR title + text. pylint checks have been failing before already