[DEV] use `pyhgtmap` instead of `phyghtmap` for generating contour lines - Githubissues

treee111 / wahooMapsCreator

Create maps for Wahoo device based on latest OSM maps

247 stars 25 forks source link

[DEV] use `pyhgtmap` instead of `phyghtmap` for generating contour lines #234

Open treee111 opened 9 months ago

treee111 commented 9 months ago

This PR…

switches to file-versioned and published (PyPi) python module pyhgtmap
no manual (kind of difficult) installation of phyghtmap needed anymore
closes #217

Considerations and implementations

Till now, there is no support for Windows, see https://github.com/agrenott/pyhgtmap/issues/7

ToDO

adjust documentation fix version of pyhgtmap and think of other publish-related stuff for this PR

How to test

create environment gdal-dev-pyh using env .yml file
switch to the environment
swith to this branch
Run wahooMapsCreator and include contour lines using -con
Check if the result is the same as using phyghtmap

Pull Request Checklist

[x] Reviewed the Contributing Guidelines
- Especially the Pull-Requests section
[x] Commits (and commit-messages) are understandable
[x] Tested with macOS / Linux
[ ] Tested with Windows

alfh commented 9 months ago

I think we can just use pyhgtmap with "jobs=1", then no forking is attempted, and it should work on windows as well. And then rather use asyncio to launch several instances of pyhgtmap. I'll do some testing on linux first and then on windows.