treee111 / wahooMapsCreator

Create maps for Wahoo device based on latest OSM maps
GNU General Public License v3.0
248 stars 25 forks source link

[FIX] Return error code of failed subprocess instead of success (which is the default) #254

Closed luusl closed 6 days ago

luusl commented 3 weeks ago

Although a subprocess fails during map creation, the return code of the wahoomc process is 0, i.e. good. This PR returns the code of the subprocess in case of an error so it's possible to determine if the map creation really succeeded.

treee111 commented 6 days ago

Hi @luusl, thanks for this PR! This indeed was not working OK since now because the default returned is 0 what means success (https://docs.python.org/2/library/sys.html#sys.exit). As you pointed out. 👍