search

treeform / genny

Generate a shared library and bindings for many languages.
MIT License
224 stars 9 forks source link

Pixie related code still in Genny #21

Open chrisheller opened 2 years ago

chrisheller commented 2 years ago

Just took a quick perusal of this. Looks great.

I did notice that there are a few places where there is some Pixie related code still hanging around though. For example, in the exportObjectNim proc in genny/languages/nim.nim, there is a hard-coded check for some Pixie related types (Vector2, Matrix3, etc.)

genny/languages/python.nim also has this (e.g. mapping Vec2 to Vector2 in exportTypePy).

I'm guessing that is just from the re-factoring to split Genny out of Pixie and into its own project though.

guzba commented 2 years ago

Yep that is correct. We're removing hard-coded bits like this as we add a means to accomplish the same thing within the Genny DSL. We still need to sort out some type name re-mapping stuff and also errors (PixieError is hardcoded iirc). These will be sorted soon.