Add url field to Response

treeform / puppy

Puppy fetches via HTTP and HTTPS

MIT License

184 stars 27 forks source link

Add url field to Response #97

Closed its5Q closed 1 year ago

its5Q commented 1 year ago

By default, puppy follows redirects, but has no way to know the final URL. This PR adds url field to Response object, allowing to get the final URL after redirects. New redirect test passes on:

Windows with WinHTTP
Linux with libcurl
MacOS with AppKit & libcurl

I couldn't test on Windows with libcurl, but I'm assuming it should work too. Addresses #96

treeform commented 1 year ago

Wow looks really good! You got all platforms and tests. We do think having URL that redirects is important.

Thank you for the PR!