search

treehouses / treehouses.github.io

A Markdown Wiki for treehouses 🏡
http://treehouses.io
132 stars 107 forks source link

Inconsistent number of required reviews for pull request. #378

Closed jorgitoooo closed 4 years ago

jorgitoooo commented 4 years ago

Problem

Not a huge problem but I noticed an inconsistency in the Github and Markdown page. The last sentence of the second to last paragraph states that three approving reviews are required to merge your Markdown profile, but the actual number of required reviews for a pull request to be merged is two.

Steps to reproduce the problem

N/A

Screenshots

issue_1_1 issue_1_2

Proposed solution

Two things can be done here:

  1. We can modify the pages/vi/githubandmarkdown.md itself and reduce the number to two. or
  2. A repository administrator can increase the number of required reviews to three by following these steps.
dogi commented 4 years ago

@garciaj92 good job ... we dropped it from 3 to 2

jorgitoooo commented 4 years ago

@dogi Great. I'd like to be assigned to this issue if possible.