treehouses / treehouses.github.io

A Markdown Wiki for treehouses 🏡
http://treehouses.io
132 stars 107 forks source link

Incorrect Section Heading in Github Issues Page #546

Closed zigmd closed 4 years ago

zigmd commented 4 years ago

Problem

In the GitHub Issues page, the section "Create a New Branch" is wrongly labeled.

The heading should instead be "Sync Your Fork" because the four commands below have been listed in detail in the previous step (Step 5).

The heading "Create a New Branch" should come after the four commands.

Steps to reproduce the problem

N/A

Screenshots

image

Proposed solution

Rename "Create a New Branch" to "Sync Your Fork"

piyush-sharma commented 4 years ago

Makes sense 👍. For the proposed solution, let's rename "Create a New Branch" to "Sync Your Fork" just as you said but then we also include the "Create a New Branch" heading right after the four commands.

zigmd commented 4 years ago

Yes Piyush, I've mentioned that "Create a New Branch" should come after the four commands in the last part of the Problem section.

piyush-sharma commented 4 years ago

What I meant to say was add that part to the proposed solution section as well so that it's more clear. Otherwise looks good!

LordJashin32 commented 4 years ago

I will approve.

zigmd commented 4 years ago

Done. @piyush-sharma Checkout #553

zigmd commented 4 years ago

553 fixed this