treethought / flask-assistant

Framework for Building Virtual Assistants with Dialogflow and python
Apache License 2.0
379 stars 101 forks source link

Implement parameter conversion #78

Closed gmolau closed 6 years ago

gmolau commented 6 years ago

The action function decorator always had a convert argument, but it's functionality was never implemented. This adds the conversion logic to _map_params_to_view_args, following the implementation in flask-ask wherever possible.

Note that the shorthand implementations don't need any regex matching as in flask-ask because Dialogflow returns irregular date/time values as normal ISO-8601 strings (e.g. "this summer" becomes 2018-06-01/2018-08-31).

treethought commented 6 years ago

Looks great, thanks @gmolau!