treethought / flask-assistant

Framework for Building Virtual Assistants with Dialogflow and python
Apache License 2.0
379 stars 101 forks source link

Condense multiple log messages for the same issue #91

Closed gmolau closed 5 years ago

gmolau commented 6 years ago

The current approach produces up to five log messages for a single issue, including one with just an empty string as the message. This makes log analysis more complicated, it is probably better to condense all desired information into a single message.

I would actually suggest to remove the _*dump() functions entirely, as log messages shouldn't come with formatting and using standard log.error(msg) calls would probably make the code more readable.

treethought commented 5 years ago

thanks @gmolau, sorry really long delay. And I agree, I think the logging needs to be cleaned up