search

treetrnk / rollem-telegram-bot

🎲 An RPG dice rolling bot for Telegram.
https://telegram.me/rollembot
GNU Lesser General Public License v3.0
36 stars 17 forks source link

Add explosion functionality #13

Closed mattiadg closed 7 years ago

mattiadg commented 7 years ago

I edited the regular expression in order to account for explosion. Added explosion to the non-fate case, because I don't know if it's the same for fate dice.

mattiadg commented 7 years ago

It referes to Issue #12 Add handling of exploding dice using "!" in dice notation.

mattiadg commented 7 years ago

Ok, I've just noticed it's a bit more difficult than I expected, because there is an issue in message handling. I'm working at it.

treetrnk commented 7 years ago

It looks like this still doesn't actually implement exploding dice. I tried rolling 2d4! several times and the 4s were never re-rolled.

mattiadg commented 7 years ago

I tried both 3d6! and stuff like 3d6!>4 and it worked. I will check later

Il 24/Ott/2016 03:45 AM, "Nathan Hare" notifications@github.com ha scritto:

It looks like this still doesn't actually implement exploding dice. I tried rolling 2d4! several times and the 4s were never re-rolled.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/treetrnk/rollem-telegram-bot/pull/13#issuecomment-255631109, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6xoiAqvM0FSvdHG1sqdmq4z_AN5zhDks5q3A3DgaJpZM4Kd2Cq .

treetrnk commented 7 years ago

Okay. I'll have to take another look at it tonight.

mattiadg commented 7 years ago

That's what I get. Isn't it correct?

2016-10-25 20:44 GMT+02:00 Nathan Hare notifications@github.com:

Okay. I'll have to take another look at it tonight.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/treetrnk/rollem-telegram-bot/pull/13#issuecomment-256134849, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6xot6in6idVzC8Igm_bSPYo07oXL1_ks5q3k4EgaJpZM4Kd2Cq .

treetrnk commented 7 years ago

You are right. My mistake. I wasn't in the correct branch. Thanks for the help!

mattiadg commented 7 years ago

Ok nice!

Il 26/Ott/2016 03:06 AM, "Nathan Hare" notifications@github.com ha scritto:

Merged #13 https://github.com/treetrnk/rollem-telegram-bot/pull/13.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/treetrnk/rollem-telegram-bot/pull/13#event-836370480, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6xohu9-uyJVjbLmb01-nRDhBaInLRkks5q3qeDgaJpZM4Kd2Cq .