SigV4 returns wrong error for mismatched date and signed-date

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data

https://docs.lakefs.io

Apache License 2.0

4.36k stars 348 forks source link

SigV4 returns wrong error for mismatched date and signed-date #2465

Open arielshaqed opened 3 years ago

arielshaqed commented 3 years ago

When the date in the signed credentials on a SigV4 request does not match the date (or x-amz-date) on the message we return ErrMalformedCredentialDate (see function getAmzDate).

In fact we should return an explanatory SignatureDoesNotMatch. See https://docs.aws.amazon.com/general/latest/gr/signature-v4-troubleshooting.html, starting with text:

The date that you use as part of the credential must match the date value in the x-amz-date header.

github-actions[bot] commented 10 months ago

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

arielshaqed commented 10 months ago

Still an error, and users will have a harder time debugging some integrations.