search

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.48k stars 359 forks source link

Esti: TestImport fails when running locally #3341

Closed N-o-Z closed 1 year ago

N-o-Z commented 2 years ago

esti/scripts/runner.sh -r all -test.run TestImport

Result in:

01 114 98 111 115 101 69 114 114 111 114 115 34 125 10]" func=github.com/treeverse/lakefs/esti.TestImport file="/home/niro/dev/lakeFS/esti/import_test.go:68" testName=TestImport
    import_test.go:69: 
            Error Trace:    import_test.go:69
            Error:          Not equal: 
                            expected: 201
                            actual  : 500
            Test:           TestImport
--- FAIL: TestImport (6.16s)

@itai-david FYI

itaiad200 commented 2 years ago

@N-o-Z Is there a flag to skip local execution?

itaiad200 commented 2 years ago

The reason I'm asking is that this test requires access to Esti data bucket in S3, which is very restricted.

N-o-Z commented 2 years ago

I saw @itai-david added a skip if the blockstore_type is not compatible - but I didn't really dive into the code to see exactly why it failed

nopcoder commented 1 year ago

@N-o-Z I think this one should be fixed as we currently skip local block adapter.

N-o-Z commented 1 year ago

Fixed