search

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.36k stars 348 forks source link

Replace alert in UI with nice modal in case of delete #653

Closed guy-har closed 3 years ago

guy-har commented 4 years ago

Currently, all the delete actions in the UI (such as delete object, revert, delete group, remove user, etc...) are followed by a confirmation message that is showed by an alert.

We would like to change them with a nice modal.

shamikakumar commented 3 years ago

Hey I would like to tackle this issue for the upcoming hacktoberfest. Do assign this to me, thanks!

Dikshapurswani commented 3 years ago

@guy-har Could you please assign this to me?

arielshaqed commented 3 years ago

@shamikakumar do you want to proceed with this, or would you prefer that I re-assign to @Dikshapurswani ?

shamikakumar commented 3 years ago

@arielshaqed I've started working on it so I would like to proceed, thanks!

Dikshapurswani commented 3 years ago

Any other issue I could work on?

On Sun, Oct 4, 2020, 1:30 PM Shamika Kumar notifications@github.com wrote:

@arielshaqed https://github.com/arielshaqed I've started working on it so I would like to proceed, thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/treeverse/lakeFS/issues/653#issuecomment-703218490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVAGOHQFRLLYNEUXY6XBXTSJATSJANCNFSM4RZV3E6Q .

arielshaqed commented 3 years ago

/@shamikakumar :

@arielshaqed I've started working on it so I would like to proceed, thanks!

Great, looking forward to the PR!

@Dikshapurswani :

Any other issue I could work on?

Sure, please look at any of these issues with the hacktoberfest label. Yesterday we noticed that it was a bit hard to discover, so now it's even on the front page.

Thanks!

Dikshapurswani commented 3 years ago

Okay! Thank you!

On Sun, Oct 4, 2020, 5:44 PM arielshaqed notifications@github.com wrote:

/@shamikakumar https://github.com/shamikakumar :

@arielshaqed https://github.com/arielshaqed I've started working on it so I would like to proceed, thanks!

Great, looking forward to the PR!

@Dikshapurswani https://github.com/Dikshapurswani :

Any other issue I could work on?

Sure, please look at any of these issues with the hacktoberfest label https://github.com/treeverse/lakeFS/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest. Yesterday we noticed that it was a bit hard to discover, so now it's even on the front page https://github.com/treeverse/lakeFS.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/treeverse/lakeFS/issues/653#issuecomment-703246916, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVAGOHEFBYURGY4YS4S3CLSJBRLZANCNFSM4RZV3E6Q .