Open yonipeleg33 opened 3 months ago
@yonipeleg33 This is not a bug, it's a feature request. Do we have any compelling business reason to add it?
@N-o-Z I was not aware of it being a feature request, and it sounds weird to me, TBH - if you don't want to use the read_only
flag, just don't use it, what is the motivation behind requesting a feature to remove an optional argument?
Anyway, I opened the bug because I wanted to use this flag and couldn't, and simply assumed it was a missing implementation, no business-y reason.
@N-o-Z I was not aware of it being a feature request, and it sounds weird to me, TBH - if you don't want to use the
read_only
flag, just don't use it, what is the motivation behind requesting a feature to remove an optional argument?Anyway, I opened the bug because I wanted to use this flag and couldn't, and simply assumed it was a missing implementation, no business-y reason.
What I meant is that the issue you opened is a feature request and not a bug. There was no requirement to support read_only mode in HL Python SDK (it also didn't exist at the time). The purpose of the HL SDK is to provide a simple and user friendly interface for lakeFS in python, not to support all the available functionality - we have the underlying Python SDK for that.
Oh.
So yeah, you can call that a feature request instead of a bug.
I think read_only
is worthy enough of being added to the higher level APIs the HL SDK provides. That's why I marked it as a bug. But arguably, it can be thought of as a feature request.
LMK whether I should change the title and description accordingly, I'm fine with either way.
read_only
is used mostly internally, I can't think of a user scenario where they'd want to create a read only repo.
You can change the title if you want, I think the discussion we had here also provide enough relevant context
What happened?
The Python wrapper is not familiar with the
read_only
optional argument that can be passed to thecreateRepository
API (this is the operation id inswagger.yml
).Steps to Reproduce:
clt = Client( username="",
password="",
host="",
)
repo = lakefs.Repository(repository_id="", client=clt).create(
storage_namespace="",
read_only=True,
)
... raise ApiTypeError( lakefs_sdk.exceptions.ApiTypeError: Got an unexpected keyword argument 'read_only' to method create_repository
lakeFS version
No response
How lakeFS is installed
No response
Affected clients
No response
Relevant log output