treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

PRfD - PR Details page #8185

Closed itaigilo closed 2 months ago

itaigilo commented 2 months ago

Closes #8175

Change Description

Create the page showing the PR Details.

Also handles the navigation, and creates a scaffold fo the Create PR page (as part of it).

Note: the PR's description is currently simple test. Will change it to md viewer when I'll implement the PR edit.


PR Details
github-actions[bot] commented 2 months ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
github-actions[bot] commented 2 months ago

E2E Test Results - Quickstart

10 passed
N-o-Z commented 2 months ago

@itaigilo Since we already merged Get/Create E2E you can actually implement it now. Also, I don't see a reason not to implement the Merge logic already since this is unrelated to the PR logic

itaigilo commented 2 months ago

The only reason I'm requesting changes is that there seems to be some mix up with the PR titles and branch src-dest when going from lists to the actual PR.

@N-o-Z If I understand you correctly - the difference is because of the mock data (which is different between the GET and LIST API calls).

And regarding your comment about integrating first - I'd be happy to, but currently I have no real PRs data to test the integration of the Details page. My plan is to merge this PR, continue to creating the Create page (which will be connected to the API and will create a real PR in the KV), and then integrate the rest.

N-o-Z commented 2 months ago

The only reason I'm requesting changes is that there seems to be some mix up with the PR titles and branch src-dest when going from lists to the actual PR.

@N-o-Z If I understand you correctly - the difference is because of the mock data (which is different between the GET and LIST API calls).

And regarding your comment about integrating first - I'd be happy to, but currently I have no real PRs data to test the integration of the Details page. My plan is to merge this PR, continue to creating the Create page (which will be connected to the API and will create a real PR in the KV), and then integrate the rest.

Thanks - I guess I missed that!