treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data

https://docs.lakefs.io

Apache License 2.0

4.46k stars 359 forks source link

PRfd - Merge PR and change PR status #8209

Closed itaigilo closed 1 month ago

itaigilo commented 2 months ago

Closes #8176.

Change Description

Wire the "Merge PR" button to the API. Wire the "Close PR" button to the API, and add a "Re-open PR" button.

Also, show PR details in Markdown.

github-actions[bot] commented 2 months ago

E2E Test Results - DynamoDB Local - Local Block Adapter

github-actions[bot] commented 2 months ago

E2E Test Results - Quickstart

N-o-Z commented 2 months ago

@itaigilo Per discussion on the PRD - we do not support re-open ATM. This should be removed

itaigilo commented 2 months ago

@itaigilo Per discussion on the PRD - we do not support re-open ATM. This should be removed

Yeah I saw that - But it felt weird, that after closing all the buttons disappear.

I don't mind removing it, but it's small piece of code that's already implemented. Any good reason to not release it?

N-o-Z commented 2 months ago

@itaigilo Per discussion on the PRD - we do not support re-open ATM. This should be removed

Yeah I saw that - But it felt weird, that after closing all the buttons disappear.

I don't mind removing it, but it's small piece of code that's already implemented. Any good reason to not release it?

Yes - it complicates the state machine of the PRs. We want to reduce the scope as much as possible. I think we can be good with graying out the buttons - we don't have to remove them Whatever makes more sense to you

itaigilo commented 1 month ago

All handled, Except for the comments related to empty diffs, which will be handled in a separate PR. Merging.