treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

added "read_only" parameter to repository creation in python-wrapper\… #8280

Closed tkalir closed 1 month ago

tkalir commented 1 month ago

Closes #7848

Background

Currently the following code raises an exception

import lakefs
from lakefs.client import Client

clt = Client(
    username="<username>",
    password="<password>",
    host="<host>",
)
repo = lakefs.Repository(repository_id="<repo id>", client=clt).create(
    storage_namespace="<namespace>",
    read_only=True,
)

the exception: lakefs_sdk.exceptions.ApiTypeError: Got an unexpected keyword argument 'read_only' to method create_repository

Bug Fix

Testing Details

I ran setup.py after the code change and created both a read-only and a regular repo using Repository.create(). image

Contact Details

tkalir@gmail.com \ Tamar Kalir in slack

N-o-Z commented 1 month ago

@tkalir @itaiad200 what's the use case here? Can you please add it to the description please

N-o-Z commented 1 month ago

Closing since issue was closed as not done