treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

GC: Read commit explicitly when it is missing from prescanned commits #8282

Closed arielshaqed closed 1 month ago

arielshaqed commented 1 month ago

GC lists all commits, but it can still miss a concurrent commit. When that happens, read it directly from KV.

The issue goes into detail why this is a good idea.

Fixes #8261.

github-actions[bot] commented 1 month ago

E2E Test Results - Quickstart

11 passed
github-actions[bot] commented 1 month ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
arielshaqed commented 1 month ago

Will pull if EITHER reviewer approves, unless you approve but ask me not to pull. THANKS!