search

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

[Bug]: When stats sending fails it sends a warning #8287

Open arielshaqed opened 1 month ago

arielshaqed commented 1 month ago

What happened?

What actually happened, including error codes if applies.

Steps to Reproduce:

  1. Run lakectl in an environment that cannot send statistics.

  2. Receive a scary warning message, e.g.

    $ lakectl repo list
Warning: failed sending statistics: http: read on closed response body
  3. This confuses me and other users. The warning is confusing and has nothing to do with the success or failure of the actual command.

Expected behavior

Don't receive an error or a warning message when stats fails

lakeFS version

1.38.0

How lakeFS is installed

n/a

Affected clients

No response

Relevant log output

lakectl:

Warning: failed sending statistics: http: read on closed response body


### Contact details

_No response_
arielshaqed commented 1 month ago

Proposed resolution (discussed with several people around here): lakectl should complain about stats at level DEBUG, as should lakeFSFS and any other client. And go over lakeFS again to ensure that it doesn't complain about failing to send stats.