search

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

Fix: Copy object mtime #8291

Closed N-o-Z closed 1 month ago

N-o-Z commented 1 month ago

Closes #8290

github-actions[bot] commented 1 month ago

E2E Test Results - Quickstart

11 passed
github-actions[bot] commented 1 month ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
N-o-Z commented 1 month ago

Approving with couple of suggestions:

  • Include CompletePresignMultipartUpload & StageObject similar fixes in this PR (or at the very least open an issue for the same phenomena)
  • If there's some easy way to test it I'd add that timestamp validation there. We know it causes bug for users, so it's best to try and prevent regressions.

@itaiad200 StageObject is irrelevant since no writes to the storage are being performed. Modified the code in CompletePresignMultipartUpload though in reality it's not an issue. Added tests

N-o-Z commented 1 month ago

Gave up on adding tests - too complicated and does not justify the overhead. Tested manually