search

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

Fix: Git package error handling #8345

Closed N-o-Z closed 2 weeks ago

N-o-Z commented 2 weeks ago

Closes #8086

Change Description

Background

Parsing git shell commands response to classify into comprehensible errors, seems like some FS return different strings for the same errors.

Bug Fix

The bug resulted from difference in output when not a git repository

The fix was to lowercase the out put before comparison

Testing Details

Added unit test

Breaking Change?

No

github-actions[bot] commented 2 weeks ago

E2E Test Results - Quickstart

11 passed
github-actions[bot] commented 2 weeks ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
N-o-Z commented 2 weeks ago

This is of course cool, but also unpleasant. E.g. this code still breaks because

❯ LANGUAGE=sv   git status
På grenen docs/getting-started-on-the-project
inget att checka in, arbetskatalogen ren

will happen in some places in Northern Europe.

Perhaps open an issue to discover a proper way to run Git plumbing?

Opened https://github.com/treeverse/lakeFS/issues/8348