treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

8158 bug UI not using presign for uploading objects #8365

Open ItamarYuran opened 1 week ago

ItamarYuran commented 1 week ago

Closes #8158

Change Description

With the added changes, it is now possible to upload a file from the UI, with a minimal IAM permissions installation.

Background

See https://github.com/treeverse/lakeFS/issues/8158

Bug Fix

Root cause - the GET request for the presigned url did not include a checksum of the desired file. Solution - Adding the checksum parameter to the api for getPhysicalAddress operation

Additional info

In order to upload a file to a presigned url, there is a need to configure the bucket's CORS.

github-actions[bot] commented 1 week ago

🎊 PR Preview 4f7f2117b64c1c98dcced5ab32a2db8d8ff650bc has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8365.surge.sh

🕐 Build time: 0.013s

🤖 By surge-preview

github-actions[bot] commented 1 week ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
github-actions[bot] commented 1 week ago

E2E Test Results - Quickstart

11 passed