treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

Fix: CosmosDB EntriesIterator #8367

Closed N-o-Z closed 1 week ago

N-o-Z commented 1 week ago

Closes #8366

Change Description

Background

lakeFS panics due to nil pointer dereference in CosmosDB's EntriesIterator

Bug Fix

The cause of the bug is trying to access a member of a pointer without checking pointer validity As hard as I tried, I was not able to reproduce the issue and therefore fixed the code itself but not the reason for it. This might not be reproducible using the CosmosDB emulator. On the bright side - I've re-enabled the CosmosDB acceptance tests in the hope that this will improve our quality

Testing Details

Ran the CosmosDB KV acceptance tests

Breaking Change?

No

github-actions[bot] commented 1 week ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
github-actions[bot] commented 1 week ago

E2E Test Results - Quickstart

11 passed