search

treeverse / lakeFS

lakeFS - Data version control for your data lake | Git for data
https://docs.lakefs.io
Apache License 2.0
4.46k stars 359 forks source link

Auto-release all clients when publishing with Maven #8378

Closed arielshaqed closed 4 days ago

arielshaqed commented 4 days ago

Look what I found! This property is covered in the docs. It also allows for a manual review opportunity... but given that we don't do that, and that we test first, let's not go there.

Fixes #7974.

Tested by manually triggering a release on this branch. It finished and I see no staging repository on https://s01.oss.sonatype.org/#stagingRepositories. Naturally we will need to wait to see whether a release test-auto-release actually made it to Maven central.

But it's worth pulling even now, in the worst case we still need to do something extra.

Isan-Rivkin commented 4 days ago

Nice!

github-actions[bot] commented 4 days ago

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed
github-actions[bot] commented 4 days ago

E2E Test Results - Quickstart

11 passed
arielshaqed commented 4 days ago

Also worth noting the beautiful XML inheritance model for pom.xml. This affects all 3 Java clients.

arielshaqed commented 4 days ago

Thanks!