USDA Leaf Retention mapping states "null" rather than "false" or "no" - Githubissues

treflehq / trefle-api

🍀 Trefle is a botanical JSON REST API for plants species, allowing you to search and query over all the registered species, and build the next gardening apps and farming robots.

https://trefle.io

GNU Affero General Public License v3.0

476 stars 50 forks source link

USDA Leaf Retention mapping states "null" rather than "false" or "no" #34

Open charitygrace opened 4 years ago

charitygrace commented 4 years ago

Describe the bug The USDA Leaf Retention field maps correctly when the USDA reports a "Yes" value. Trefle states "true". However, when the USDA reports a "No" value, Trefle does not report a value and simply states "null". "null" and "false" are not the same thing.

To Reproduce To see "Yes" correctly mapped to "true": https://plants.sc.egov.usda.gov/java/charProfile?symbol=ABFR https://trefle.io/api/species/101129

To see "No" incorrectly mapped to "null": https://plants.sc.egov.usda.gov/java/charProfile?symbol=ACSA3 https://trefle.io/api/species/101870

lambda2 commented 4 years ago

Indeed ! Thanks for the report !