search

trek-view / gopro2gsv

Processes .jpg images and .mp4/.360 videos shot on GoPro MAX or Fusion cameras and uploads to Google Street View.
Apache License 2.0
4 stars 0 forks source link

Mode 2 is failing #39

Closed himynamesdave closed 9 months ago

himynamesdave commented 9 months ago

Some attempted tests

Testing smooting with one bad GPS point (with custom value 20m/s set)

A note on how to corrupt GPS (for this test case smoothing)

exiftool -overwrite_original -GPSLatitude=40.6892 -GPSLatitudeRef=N -GPSLongitude=-74.0445 -GPSLongitudeRef=W -GPSAltitude=10 -GPSAltitudeRef="Above Sea Level" tests/UKHB001v205-some-bad-gps/GSAA7186.JPG
exiftool -overwrite_original -GPSLatitude=20.1 -GPSLatitudeRef=N -GPSLongitude=-60.1 -GPSLongitudeRef=W -GPSAltitude=10 -GPSAltitudeRef="Above Sea Level" tests/UKHB001v205-some-bad-gps/GSAA7196.JPG
python3 gopro2gsv.py \
    --input_directory tests/UKHB001v205-some-bad-gps/ \
    --outlier_speed_meters_sec 20 \
    --output_filepath tests/output/mode2/test1/UKHB001v205-some-bad-gps.mp4

Testing maximum output video length (simple)

python3 gopro2gsv.py \
    --input_directory tests/UKHB001v205-frames-removed/ \
    --max_output_video_secs 20 \
    --keep_extracted_frames \
    --output_filepath tests/output/mode2/test2/UKHB001v205-frames-removed.mp4

Produce

(gopro2gsv-venv) dgreenwood@Davids-MBP-2 gopro2gsv % python3 gopro2gsv.py \
        --input_directory tests/UKHB001v205-frames-removed/ \
        --max_output_video_secs 20 \
        --keep_extracted_frames \
        --output_filepath tests/output/mode2/test2/UKHB001v205-frames-removed.mp4
28-Nov-23 15:02:44 [GoPro2GSV] [INFO] ====================================================
28-Nov-23 15:02:44 [GoPro2GSV] [INFO] =====================GoPro2GSV======================
28-Nov-23 15:02:44 [GoPro2GSV] [INFO] ====================================================
28-Nov-23 15:02:44 [GoPro2GSV] [INFO] Saving log to `/Users/dgreenwood/Documents/repos/trek-view/gopro2gsv/tests/output/mode2/test2/UKHB001v205-frames-removed.log`
28-Nov-23 15:02:44 [GoPro2GSV] [INFO] =====================GoPro2GSV======================
    1 directories scanned
  589 image files read
Traceback (most recent call last):
  File "/Users/dgreenwood/Documents/repos/trek-view/gopro2gsv/gopro2gsv.py", line 5, in <module>
    main(*parse_args())
  File "/Users/dgreenwood/Documents/repos/trek-view/gopro2gsv/src/__main__.py", line 212, in main
    gopro2gsv(args, is_photo_mode, logger)
  File "/Users/dgreenwood/Documents/repos/trek-view/gopro2gsv/src/__main__.py", line 129, in gopro2gsv
    valid_images, invalid_files = get_files_from_dir(input_dir)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/dgreenwood/Documents/repos/trek-view/gopro2gsv/src/imagetool.py", line 53, in get_files_from_dir
    metadata = metadata_dict(metadata)
               ^^^^^^^^^^^^^^^^^^^^^^^
TypeError: metadata_dict.__init__() takes 1 positional argument but 2 were given