search

trek10inc / awsume

A utility for easily assuming AWS IAM roles from the command line.
https://awsu.me
MIT License
487 stars 90 forks source link

fix SAML parsing to handle any XML prefix mapping #148

Closed Tantalon closed 11 months ago

Tantalon commented 3 years ago

Fix for #81.

The XML prefixes are not always samlp/saml/etc, so we provide a mapping to the XML parser so it can translate the namespaces into the prefixes we're expecting.

Also enable force_cdata, because in testing this I saw xmltodict returning a plain string rather than {'#text': value}) whereas the code always expects it in the structured form. This ensures that xmltodict output matches the code.

relausen-tlg commented 2 years ago

We would really like this to be merged and released, since we bump into the problems that is fixed by it. Are there any updates on if and when this will happen?

KennethEgholm commented 2 years ago

Just to emphasise @relausen-tlg comment. This fix would be very helpful to us. What is the reason that it hasn't been accepted - is there anything we can do to help ?

mtskillman commented 11 months ago

@lhendrick-t10 I think we should get this one reviewed+merged first