trek10inc / awsume

A utility for easily assuming AWS IAM roles from the command line.
https://awsu.me
MIT License
485 stars 90 forks source link

#250 follow XDG standard for logging #251

Closed sriesenberg-reply closed 3 months ago

sriesenberg-reply commented 4 months ago

relates to: #250

lhendrick-t10 commented 4 months ago

Hello again @sriesenberg-reply! Thanks for the contribution! I'm reviewing the PR now but if you could update the test at test/unit/awsume/awsumepy/lib/test_config_management.py::test_load_config_no_path that will get us one step closer to merging this change!

Thank you again for helping out with awsume!

sriesenberg-reply commented 4 months ago

Adjusted the test. The issue was load_config (and with it migrate_to_xdg_base_directories) calls mkdirs 3 times instead of 2, due to the new logs directory.