trek10inc / serverless-secrets

An opinionated tool for safely managing and deploying Serverless projects and their secrets.
Other
165 stars 27 forks source link

Correct config object structure. #20

Closed modmac closed 6 years ago

modmac commented 6 years ago

Client part uses {options: ..., environments: ... } object as a config, but plugin was creating wrong config file structure - all options were set directly in config object (without options inner object) .

azurelogic commented 6 years ago

@modmac Do the tests still run? I don't have auto CI set up on this repo, and I don't have time at the moment to pull this locally and check. Thanks!

modmac commented 6 years ago

All tests passed, but there's no test file for plugin/index.js.

Even client test assumes config file with options key:

const defaultSecrets = {
  options: {
    provider: 'aws',
    throwOnMissingSecret: true,
    logOnMissingSecret: false,
    skipValidation: false
  },
  environments: {
    $global: {},
    testFunction: {}
  }
}
azurelogic commented 6 years ago

Ah, sorry, I see it all now. I reviewed this far too quickly the other day. Thanks for catching this!