Closed modmac closed 6 years ago
@modmac Do the tests still run? I don't have auto CI set up on this repo, and I don't have time at the moment to pull this locally and check. Thanks!
All tests passed, but there's no test file for plugin/index.js
.
Even client test assumes config file with options
key:
const defaultSecrets = {
options: {
provider: 'aws',
throwOnMissingSecret: true,
logOnMissingSecret: false,
skipValidation: false
},
environments: {
$global: {},
testFunction: {}
}
}
Ah, sorry, I see it all now. I reviewed this far too quickly the other day. Thanks for catching this!
Client part uses
{options: ..., environments: ... }
object as a config, but plugin was creating wrong config file structure - all options were set directly in config object (withoutoptions
inner object) .