Fluent interface added to Form

trekawek / air-quality-info

An attractive way to display air quality in your neighbourhood.

Other

49 stars 16 forks source link

Fluent interface added to Form #73

Closed tybulewicz closed 3 years ago

tybulewicz commented 3 years ago

Forms' fluent interface is now typed allowing for IDE inspection.

trekawek commented 3 years ago

@tybulewicz, FYI following warning is logged now:

fpm_1 | NOTICE: PHP message: PHP Warning: Declaration of AirQualityInfo\Admin\Controller\DeviceHierarchyController::addNameField(AirQualityInfo\Lib\Form\Form $deviceForm, $breadcrumbs) should be compatible with AirQualityInfo\Admin\Controller\AbstractController::addNameField(AirQualityInfo\Lib\Form\Form $deviceForm) in /var/www/html/admin/controller/device_hierarchy_controller.php on line 193

It's possible it was present before, though.

trekawek commented 3 years ago

My mistake. Now I think it doesn't make sense to override the method in DeviceHierarchyController at all. Fixed in 53a4e38c8ed516e8bd4123037304178aef67d7cc.