trekcc-ops / gemp-stccg

2 stars 0 forks source link

Remove LotR Phases #2

Open datanoh opened 1 month ago

datanoh commented 1 month ago

Pieces of the code that still rely on LotR-specific phases (Fellowship, Maneuver, Archery, Assignment, Skirmish, and Regroup).

Auto-pass - this is the only piece of the code still using LotR-specific Phase enum values, in GameRequestHandler.java. Should be able to just use Star Trek phases here instead.

Other client code:

datanoh commented 5 hours ago

@andrewd18 - Moving this to MVP for discussion. For MVP, I'd like to either hide the client auto-pass options, or set them to correct phase names for the game being played. It may be a bit tricky - I don't fully understand how the autopass works. I set them all to false a while back by default, and they haven't been tested (even manually) since then.

Client code pasted below. Any thoughts on your end? Stuff we should dig into and/or test? Worth getting into for MVP?

https://github.com/trekcc-ops/gemp-stccg/blob/32b8220f83ba3d7c8b509df778c0af048b258771/gemp-module/gemp-stccg-client/src/main/web/js/gemp-022/gameUi.js#L75

https://github.com/trekcc-ops/gemp-stccg/blob/32b8220f83ba3d7c8b509df778c0af048b258771/gemp-module/gemp-stccg-client/src/main/web/js/gemp-022/gameUi.js#L402-L443