search

trekhleb / javascript-algorithms

📝 Algorithms and data structures implemented in JavaScript with explanations and links to further readings
MIT License
185.13k stars 29.86k forks source link

Could we have just one way of doing the swapping to have better consistency across the code #314

Open cjkumaresh opened 5 years ago

cjkumaresh commented 5 years ago

Like how we have here https://github.com/trekhleb/javascript-algorithms/blob/master/src/algorithms/sorting/bubble-sort/BubbleSort.js#L22 instead of https://github.com/trekhleb/javascript-algorithms/blob/master/src/algorithms/sorting/shell-sort/ShellSort.js#L24

ktrongnhan commented 5 years ago

The former makes use of ES6 destructuring whilst the latter does not. I think the question is whether ES6 is recommended in this project

mik-laj commented 5 years ago

I feel that this project is trying to use modern language standards. I support the use of ES6 destructuring.

ekner commented 2 years ago

Hi, we are four students working on this issue as part of a course in software development.