search

trelau / AFEM

Airframe Finite Element Modeler
GNU Lesser General Public License v2.1
40 stars 16 forks source link

add typehints #11

Open jf--- opened 3 years ago

jf--- commented 3 years ago

as it says on the tin -- I think typehints would be a welcome addition. @trelau would you accept such a PR, since that would basically make the project python>=3.6+?

trelau commented 3 years ago

Yes, I think so. AFEM depends on pyOCCT which is only supported for 3.6 and above.

As a side note, I've been trying to migrate pyOCCT and pySMESH to latest versions (OCCT 7.5.0 and SMESH 9.6.0) but hit a snag here https://github.com/trelau/SMESH/issues/37. Note I also broke out pySMESH from pyOCCT.

jf--- commented 3 years ago

Great to see the 7.5 update is nearby... The smesh breakout is a solid idea... Great, I'll horse around wrt type hints...

I understand that the issue wrt SMESH is mostly osx related?

trelau commented 3 years ago

Yes it seems osx related and so far has me stumped (and i don't have a local osx system to quickly debug...)

jf--- commented 3 years ago

Understood. Is this keeping you from releasing the breakout version of (pay)smesh & pyocct (occt 7.5)?

trelau commented 3 years ago

Yes. I’d like to get pyocct, smesh, and pysmesh fully updated to latest versions of OCCT (7.5) and Salome (9.6) and update the conda feedstock for SMESH. Then refresh afem with new libraries.