search

trelau / SMESH

Mesh module from the Salome Platform
GNU Lesser General Public License v2.1
50 stars 31 forks source link

Int 32 test #68

Closed looooo closed 9 months ago

looooo commented 2 years ago

for the compatibility with freecad SALOME_USE_64BIT_IDS shouldn't be defined. What do you think @trelau?

looooo commented 2 years ago

https://github.com/conda-forge/smesh-feedstock/pull/60#issuecomment-1179732900

trelau commented 2 years ago

Not sure why tests are failing with that could not find catch2 error...

at a glance this output and what's just below it seems strange...

https://github.com/trelau/SMESH/runs/7283531656?check_suite_focus=true#step:8:518

trelau commented 2 years ago

Also it looks like there is a commit to use SMESH 9.9.0. I think that should be in a separate PR. That is, get this working for the "Int 32 test" and then update to 9.9 separately. Hard to know what impact that could have.

looooo commented 2 years ago

@trelau, there is a newer catch2 version which might be pulled. This new catch2 version has a new interface: catch_all.hpp. So one way is to pin the old version. The other way is to update smesh to use the new interface.

Not sure why I updated to smesh v9.9.0. I guess this should be reverted.

In addition we see some linking issues with windows. Our guess is that windows still uses int64 although -DSALOME_USE_64BIT_IDS is not declared.

trelau commented 9 months ago

@looooo still relevant after #73 ?

looooo commented 9 months ago

No.