search

trelau / pyOCCT_binder

Binding generator for pyOCCT project
GNU Lesser General Public License v2.1
7 stars 1 forks source link

Try to detect a ref rtype for #14 #15

Closed frmdstryr closed 4 years ago

frmdstryr commented 4 years ago

I'm not sure if this is correct, Is there a way to test this with CI?

trelau commented 4 years ago

@frmdstryr just opend a PR with some changes. Seems that libclang doesn't detect the lvalue and const correctly so just sticking with the string based approach. it also adds some (hideous) unit test framework and CI. lots more can be done in the testing to clean it up, but just wanted to set it up. can carry on that discussion in one of the issues that i filed for it

frmdstryr commented 4 years ago

this might not be possible in c++, but do we know of any methods in OpenCASCADE that have the same method name, but are overloaded by one returning the const version and the other not?

Looks like that It is possible, not sure what pybind does in that case? I suppose it would just overwrite one or the other, but in either case shouldn't the return policy should be left at auto?

Idk what happens if python tries to modify an object that's a const ref which is why I was using auto (don't know if that's correct or not).

Added a log statement, feel free to push commits (or just do a new PR).