search

trelau / pyOCCT_binder

Binding generator for pyOCCT project
GNU Lesser General Public License v2.1
7 stars 1 forks source link

Use pname for cpp class name #26

Closed frmdstryr closed 2 years ago

frmdstryr commented 2 years ago

Changes:

  1. Makes the +pname also rename the cpp class to avoid duplicate definition errors caused by templates (eg https://github.com/trelau/pyOCCT/pull/95/files#diff-7206418f088df5bcafb72d1a2ef6c5c4773fdd0f0c7bb14be7f5dbfcd4d606e1R784-R785).

  2. Also I took the liberty to wrap the config parser int a try/except block to print the failing line number if there is a typo in the config file.

trelau commented 2 years ago

@frmdstryr thanks. would it be possible to add a simple test for the +pname changes? Can just exit the example and "expected" files to cover this behavior to make sure it stays consistent. Just trying to avoid changes in the binder breaking downstream tools that use it (i.e., pyOCCT).