search

trellis-ldp / trellis

Trellis is a platform for building scalable Linked Data applications
https://www.trellisldp.org
Apache License 2.0
105 stars 21 forks source link

Normalize class names #461

Closed acoburn closed 5 years ago

acoburn commented 5 years ago

The various no-op service implementations all follow a standard naming convention: org.trellisldp.<module>.NoopXService, but the other service implementations really don't.

We have some DefaultXService classes, and several backend-specific classes (e.g. TriplestoreResourceService. Those are fine, but others ought to be reviewed.

As such, I'd like to propose the following changes:

o.t.agent.SimpleAgentService         =>  o.t.agent.DefaultAgentService
o.t.rdfa.HtmlSerializer              =>  o.t.rdfa.DefaultRdfaWriterService
o.t.event.EventSerializer            =>  o.t.event.DefaultActivityStreamService
o.t.constraint.LdpConstraints        =>  o.t.constraint.LdpConstraintService
o.t.ampq.AmqpPublisher               =>  o.t.amqp.AmqpEventService
o.t.jms.JmsPublisher                 =>  o.t.jms.JmsEventService
o.t.kafka.KafkaPublisher             =>  o.t.kafka.KafkaEventService
o.t.namespaces.NamespacesJsonContext =>  o.t.namespaces.JsonNamespaceService

Other suggestions are welcome.

ajs6f commented 5 years ago

👍 except DefaultConstraintService. I think LdpConstraintService is more descriptive. The fact that it is on by default isn't as important as the fact that it provides a lot of LDP behavior.

acoburn commented 5 years ago

I like your suggestion. I'll update the proposal to use LdpConstraintService