trello-archive / victor

Use SVGs as resources in Android
Apache License 2.0
1.01k stars 49 forks source link

Handle invalid svgs gracefully #8

Closed dlew closed 9 years ago

dlew commented 9 years ago

Addresses #7

hamidp commented 9 years ago

I might be missing something but to me it seems like an invalid svg is like invalid code, so the right behavior would be to error out.

dlew commented 9 years ago

I'm taking a note from the standard Android build process which does keep processing files even if they're invalid (in some cases). Not sure what the best practice here is though.

At the very least, this gives us points at which we could throw exceptions instead of logging warnings.

hamidp commented 9 years ago

Ah, :+1: