Change variable arp_op to arp_opcode to avoid name collision with netinet/ether.h

trema / trema-edge

Transient repository for Trema OF1.3 branch

27 stars 14 forks source link

Change variable arp_op to arp_opcode to avoid name collision with netinet/ether.h #117

Closed charlesmcchan closed 10 years ago

charlesmcchan commented 10 years ago

The detail problem description could be found here on trema-dev

A test example could be found here: Makefile arp_opcode_test.c After updating trema-edge to this version, we no longer need to #undef arp_op anymore while using netinet/ether.h

yasuhito commented 10 years ago

Thanks!

charlesmcchan commented 10 years ago

The interface append_oxm_match_arp_op() is now changed to append_oxm_match_arp_opcode() due to the change of the field name. This modification requires all existing applications to change the function name.

Maybe adding an exception to src/switch/switch/oxm-helper.c line 486 APPEND_OXM_MATCH( arp_op ) is a better solution?